Skip to content

Conversation

@bmagyar
Copy link
Member

@bmagyar bmagyar commented Jul 17, 2025

Supersedes #1756

Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@christophfroehlich
Copy link
Contributor

@bmagyar the new test is failing, could you have a look please?

destogl
destogl previously approved these changes Jul 21, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open for 45 days with no activity. Please tag a maintainer for help on completing this PR, or close it if you think it has become obsolete.

@github-actions github-actions bot added the stale label Oct 13, 2025
@mergify
Copy link
Contributor

mergify bot commented Oct 13, 2025

This pull request is in conflict. Could you fix it @bmagyar?

@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.13%. Comparing base (63bae1b) to head (869ffa4).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1820      +/-   ##
==========================================
+ Coverage   85.11%   85.13%   +0.01%     
==========================================
  Files         143      143              
  Lines       13740    13755      +15     
  Branches     1201     1201              
==========================================
+ Hits        11695    11710      +15     
  Misses       1638     1638              
  Partials      407      407              
Flag Coverage Δ
unittests 85.13% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ory_controller/src/joint_trajectory_controller.cpp 83.88% <100.00%> (+0.03%) ⬆️
joint_trajectory_controller/src/trajectory.cpp 91.62% <100.00%> (+0.04%) ⬆️
...ory_controller/test/test_trajectory_controller.cpp 99.80% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich changed the title [JTC] added time_from_start to action feedback (#1755) [JTC] added time_from_start to action feedback and state message (cherry-pick #1755) Nov 3, 2025
@christophfroehlich christophfroehlich changed the title [JTC] added time_from_start to action feedback and state message (cherry-pick #1755) Add time_from_start to action feedback and state message (cherry-pick #1755) Nov 3, 2025
@christophfroehlich christophfroehlich merged commit 4c4a13e into ros-controls:master Nov 3, 2025
17 checks passed
mergify bot pushed a commit that referenced this pull request Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants